Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: preview_pages用のWorkflowを追加 #2342

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

https://github.com/sevenc-nanashi/vv-preview-demo-page を持ってきました。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner November 5, 2024 11:19
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team November 5, 2024 11:19
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!!

もう明日には動きそう!!! 楽しみですね!!!

.github/workflows/update_preview.yml Outdated Show resolved Hide resolved
.github/workflows/update_preview.yml Outdated Show resolved Hide resolved
.github/workflows/update_preview.yml Outdated Show resolved Hide resolved
.github/workflows/update_preview.yml Outdated Show resolved Hide resolved
.github/workflows/trigger_preview.yml Outdated Show resolved Hide resolved
.github/workflows/trigger_preview.yml Outdated Show resolved Hide resolved
Comment on lines 10 to 13
push:
branches:
- main
- project-*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ただのコメントです)

これ今思いついたんですが、将来的にTAGごとにプレビューページデプロイできると便利かもですね!!
過去バージョンのビルドが確認できそう。

.github/workflows/trigger_preview.yml Outdated Show resolved Hide resolved
.github/workflows/trigger_preview.yml Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

こちらは一旦マージしてしまっても良いかもですね!

📝 タスク

  • TRIGGER_PREVIEW_PAGES_TOKEN

.github/workflows/DANGEROUS_trigger_preview_pages.yml Outdated Show resolved Hide resolved
@Hiroshiba
Copy link
Member

準備できたのでマージします!!

@Hiroshiba Hiroshiba merged commit 6355ee9 into VOICEVOX:main Nov 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants